search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 245 forks source link

Error on "going back" while installing plugin #121

Closed TheBenji closed 10 years ago

TheBenji commented 10 years ago

If you for example try to install a plugin and while the plugin is installing you're going back to the dashboard the server crashes with an error and won't start again (until you delete the folder in node_modules).

The problem seems to be that basically everything just gets killed if you leave the page. That is in this case pretty bad because you'll destroy your whole environment but also quite annoying if you listen to music and you're going back. Would be nice if the music would still play like you know it from XBMC

jansmolders86 commented 10 years ago

Hi there,

Very good point @theBenji! I will definitely add functionality so the install is executed properly even if you go back! The reason why this issue occurs and the reason the music does not play outside the music page is that every tile on the homescreen is a seperate app running in the same node instance. While asynchronous, meaning you can open a second tab in your browser just for the music app, it is pretty difficult to allow app functionality to extend beyond its own enviorment so to speak. I've already put it on this feature on my trello todo list so I will definitely get around to it!

Thanks again for your testing and interest in the project!

jansmolders86 commented 10 years ago

I pushed a crude temporary fix for this issue. The back button is hidden when a operation is preformed. A more robust fix will be implemented later down the line. I've made a ticket in trello for it! :)

Thanks again!