search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 245 forks source link

Vector images and hide option for movies #135

Closed Jon889 closed 10 years ago

Jon889 commented 10 years ago

Apps can have vector images (works on basically all browser versions, falls back to PNG), The vectors should be 160x165 not 160x169 like PNGs. The plugins app only restarts the server when you click back if a plugin has been installed/upgraded/removed. And when the server does restart it shows a message saying whats happening. Also fixed the plugins app (and possibly the music and tv apps) which I broke in an earlier commit (sorry) Added a delay to the Movie's app backdrop changing on hover, so it doesn't flash when moving from one movie to another.

jansmolders86 commented 10 years ago

This is beyond amazing Jon! I can't thank you enough for this amazing amount of work! How would you feel being a collaborator?

Jon889 commented 10 years ago

That would be great! Thanks :)

About the movie playback, is it meant to transcode the whole movie first before playback starts?

jansmolders86 commented 10 years ago

Thank you Jon! I'll add you so you can work/push to the master. Please add new features of potential breaking development in a branch so the master will stay stableish :)

To answer your question: No, It should start transcoding and play the video as well. These actions should work parallel.

Jon889 commented 10 years ago

That's strange, it doesn't play for me, it also seems to transcode the video even if it's already been transcoded

jansmolders86 commented 10 years ago

If the transcoding did not finish correctly, it will retranscode the movie as the application can't be sure the file is not corrupted.

What system are you on? Windows or Linux? Do you see an endless loading spinner? Or just a black screen? Also, what does the console say?

Jon889 commented 10 years ago

I'm on Mac, it shows the player but keeps the spinner on a black background. The console just shows the ffmpeg output as expected

jansmolders86 commented 10 years ago

Which browser do you use? What does the console of the browser say? Does videojs give an error?

@hoffi Does playback work for you since you are on a mac as well?

I'll test tomorrow on a mac at work during my lunchbreak :)

jansmolders86 commented 10 years ago

Ow btw! what does the setting "transcoding quality" say?

Jon889 commented 10 years ago

I tried on Chrome and it worked. It seems to be a problem with Safari, because if I got to the file directly (as in file:///Users/jonathan/mediacenterjs/public/data/movies/Star-Wars-The-Phantom-Menace.mp4) it doesn't load.However if I load another shorter and already transcoded video in the same manner it plays, but if I play this short video through MCJS it still just shows the spinner.

So it seems like it's something about Safari not liking playing partially transcoded videos.

I've tried on low and high quality and it has no effect.

Jon889 commented 10 years ago

It seems Safari is a bit retarded for lack of a better word when it comes to HTML5 audio and video: http://stackoverflow.com/questions/3639604/html5-audio-video-and-live-transcoding-with-ffmpeg?lq=1 http://stackoverflow.com/questions/1995589/html5-audio-safari-live-broadcast-vs-not

jansmolders86 commented 10 years ago

Yup, I was affraid of that. Only Chrome and firefox (mostly) push the browser into the future/modern day with html5 video/audio support. Other browsers are still very lacking. I can get it to work for safari though but I'd need to implement a whole new transcoding set based on hls which is not that high on the priority list. It does work for ios devices though :)

Jon889 commented 10 years ago

Ah, it's not worth it at all then. Though perhaps having videoJS reverting to flash in Safari would work?