jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 243 forks source link

Current installation breaks on Windows #137

Closed jansmolders86 closed 10 years ago

jansmolders86 commented 10 years ago

Hej Jonathan,

I tried to fire up my version of MCJS (clean setup) and it seems to break on start up.

image

I can probably debug this but I believe you might know faster what the problem might be. It worked just fine a couple of commits back.

Jon889 commented 10 years ago

I just cloned the repo to a new folder and tried it, and it worked without errors. I'll try on Windows.

jansmolders86 commented 10 years ago

Thanks man! I can try on my work pc on monday as well just to be sure

Jon889 commented 10 years ago

I tried on windows and got the same error as you did, however I went back through the commits (repetitively alternating git checkout HEAD^ and node server.js) and it came up with the same message every time. So it seems to be something external like node js being updated?

Also I tried node index.js and I get the same message about child process and spawn, which seems odd as far as I know there is no other process spawned other than what server.js does.

jansmolders86 commented 10 years ago

You are right. That was the first thing I tried as well. The pc at my work has an older nodejs version so that might explain why it still worked there. Or maybe it has something to do with the version of express. I''m going to dig around, if you have the chance to do the same I would be very grateful.

Jon889 commented 10 years ago

I tried running it with node-inspector, and it originates from onexit callback for the node process. So I tried just uncommenting everything in index.js and putting parts back in. Removing app.configure(...) doesn't show the error, so it seems to a problem with express. I tried removing express and going back to version 3.0.0 (because the package.json in MCJS has that as the minimum) and same error. I'll keep looking but I have no idea atm.

jansmolders86 commented 10 years ago

Great work jonathan, I'll read up on the change logs of express and check which version I have running on the pc that still works. I think I have enough info to fix this now :) I'm extremely grateful!

jansmolders86 commented 10 years ago

So I checked at work and it works with node version 0.10.29 and 0.10.30. So it seems Express is the culprit. The version of express is now static and will check tonight if this version (3.15) works on my home laptop.

jansmolders86 commented 10 years ago

Seems to be an Express issue. Will close this for now and stick to the fixed version for now.

Thanks jonathan for helping out!