search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 243 forks source link

Loading bar not shown during initial scrape #138

Closed jansmolders86 closed 10 years ago

jansmolders86 commented 10 years ago

It seems the initial scraping results in an exception error and the loading graphic on the frontend is not show. @Jon889 Can you confirm this issue?

Jon889 commented 10 years ago

Which app is this?

jansmolders86 commented 10 years ago

Sorry, forgot to mention I got this issue with the movies, music and tv app. None of these show the circular loading thing. I just want to check if it is a local socket.io issue or if you have it as well. The exception only happend once during the loading of movies, but hasnt popped up since

Jon889 commented 10 years ago

It seems the local IP in the config data is not updating. Perhaps it would be better to remove the localIP and remote port config and let socket.io do the connection automatically, which it can do?

jansmolders86 commented 10 years ago

Can it? if that is the case it would be great! But I can definitely think of scenarios where you would like to customize it (eg when using proxies).

Jon889 commented 10 years ago

It will default to connecting to the host that serves the page according to the docs. So I assume it will work through proxies in the same way the actual content does. I'll try it on a new branch and then you can see if it works through proxies?

jansmolders86 commented 10 years ago

Sounds great man! Thanks so much!

Jon889 commented 10 years ago

I've added the branch. setup-sockets.js is a bit weird, but I wasn't sure how else to do it.

jansmolders86 commented 10 years ago

Awesome! I'll check it out ASAP! Thanks for picking this up so fast man!

jansmolders86 commented 10 years ago

Hey Jonathan!

Your edits work great! Let's merge it to master shall we? Would you like to do the honors?

I already merged Master in the branch btw :)

Jon889 commented 10 years ago

Thanks, just merged it now :)