search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 245 forks source link

Javascript Jabber plugin #14

Closed TerryMooreII closed 11 years ago

TerryMooreII commented 11 years ago

A plugin for the Javascript Jabber podcast based on the Nerdist podcast

jansmolders86 commented 11 years ago

This is really awesome! Thank you so much! How was your experience building this? Was it easy for you to make or would you suggest some alterations to the flow/system?

TerryMooreII commented 11 years ago

Writing this was super easy! I love that I can just use js/html/css to create the screens and get the data. Granted I didn't do a whole lot except modify your Nerdist plugin but I was just trying to get my feet wet.

What I think would cool is to make the plug-ins more modular. It would be awesome if I publish my plugin to npm and then from the computer running Mediacenterjs run the command npm install mediacenterjs-<plugin-name>. Basically modeled off the Yeoman project. (mediacenterjs- would be a mandatory prefix so that you could easily search out plugins in npm). This would keep your core code base clean.

One other thing. In order to run the application I have to do a chmod -R 755 (as per your instructions) however this modifies ever file and then when I go to check in my code or create a pull request it sees that ever file is modified. Do you know any way around this other than keeping two repos?

jansmolders86 commented 11 years ago

Thank you very much for giving such valuable feedback! Your 'Yeoman'-like approach is very awesome and would save me the trouble of having to write a package manager for MCJS apps! The only thing I need to figure out is (maybe you know this) if it is possible to set a custom install path for these prefixed apps. (because of the current folder structure (/app/ and public/).

Thank you for pointing out the Git issue with the file permissions. I asked a colleague with more Linux experience and he said the permission only need to be altered on the files actually using read/write/execute permissions. So the command should me more like:

    sudo chmod 755 mediacenterjs/bin/sqlite3/sqlite3 mediacenterjs/lib/database/mcjs.sqlite
TerryMooreII commented 11 years ago

I just dove deeper into your code and I have a couple of ideas that I will experiment with so that plugins will still live in the node_modules folder (for npm consistency) with hopefully minor changes to the core code base. Unfortunately, I am at work and NPM is blocked so I will have to wait until later tonight before I can do any experimenting.

I am glad that you asked your co-worker about the permissions, I figured that it wasn't everything that needed the 755 permission. Do you really need to sudo before this? I would assume that since your user account and not root that is running mediacenterjs then it would just be your account that needed those permissions. However I could be wrong and can test this later.

I really like this project and I hope that you keep it up.