search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 243 forks source link

New movie directive does not iterate #180

Closed jansmolders86 closed 9 years ago

jansmolders86 commented 9 years ago

Hey Jonathan,

I've found an issue with the new movie directive. For some reason, it does not iterate and only shows one movie. So in my test scenario I have 70 movies in my library (database confirms this) but I only see one. I haven't found the issue myself yet so I'm reaching out to you :) I'll continue to look though!

I also have an issue with the Music app btw. It doesn't group tracks in the album view anymore. I'm looking into it as well.

Thanks in advance!

Jon889 commented 9 years ago

It seems to be something on the server side, it worked fine until I cleared the cache also /movies/load is only showing one result. I think the problem is that if there is no metadata found on the TMDB it is not added to the database (line 18-20, in apps/movies/metadata-processor.js)

I can't replicate the music app issue though

jansmolders86 commented 9 years ago

That was what I was afraid of. I couldn't find a direct reason in the code. TMDB does have some fair use limitations. It might be we've run into that limit. I'll investigate further! Thanks for checking it out!

Jon889 commented 9 years ago

I think only one of my movies has a title that can be found on TMDB (the rest have a load of junk in the title), and by the code it seems the movie is only added to the database if the movie is found. I think this is because or the changes @hoffi made?

hoffi commented 9 years ago

You are right, @Jon889. Seems to be a mistake by me in the Movies and TV Metadata-Processors. Whenever no result or an error was return from TMDB, the movie or show is not added to database.

I'll look into that

hoffi commented 9 years ago

@Jon889 @jansmolders86 can you try again?

Jon889 commented 9 years ago

That works for me :)

jansmolders86 commented 9 years ago

Dito! Thanks so much!

jansmolders86 commented 9 years ago

BTW @hoffi & @Jon889 I would like to suggest we introduce a develop branch.

I was thinking we should have a master branch that's always as stable as possible and release to it on specific moments (eg, feature release)

We already create new features in a feature branch so once we're done, we can merge that feature into develop to check if everything works as expected. Especially since you guys are on Mac and I'm on Windows, that should give us some nice test scenarios.

Then once we give the all clear, one of us releases into Master. This might seem a bit heavy at first, but will ensure stable code for new users coming in.

Are you guys game for this approach?

Thanks!

hoffi commented 9 years ago

@jansmolders86 Sure. So you mean no more commit should be pushed to master except merges from develop to master? Would definitely be better as you can be sure then, that master branch is always stable.

jansmolders86 commented 9 years ago

Exactly! :) Let's make it effective from this moment forward! The Develop branch has already been added. Users can decide for themselves if they want to check out the stable master or the newer potential unstable develop branch!