search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 243 forks source link

Global Search? #183

Open hoffi opened 9 years ago

hoffi commented 9 years ago

I always like to have an "app-wide" search, which searches just everywhere it can and displays the results categorized by the containing app for example.

Not very easy to implement but what do you think?

johnpool3 commented 9 years ago

This sounds like a great idea, a bit like spotlight on a mac perhaps.

Jon889 commented 9 years ago

I started implementing this a few days ago, and it works, just knowing how to display the results is a bit ugly, I'm passing the name of the directive (view) in the list of apps (model). I've pushed the branch, there's a lot I'm unsure on the best way to implement, but I tried to do it in a way that keeps things seperate and modular.

jansmolders86 commented 9 years ago

This is awesome guys! I have a couple of thoughts on the visual implementation. Do you mind me weighing in on this as well? I don't want to step on your feature if you just want to complete it yourself!

Jon889 commented 9 years ago

Definitely! I don't know about the others, but I guess it's the same, but I don't consider anything "my" feature :)

jansmolders86 commented 9 years ago

Excellent. I just don't want to step on anyone's toes here. I fully appreciate all the hard work you guys are doing!

hoffi commented 9 years ago

Hey @Jon889 really like it already :+1:

But i would find it more useful if the search is directly on the "dashboard".

Jon889 commented 9 years ago

I quite agree :) though it seemed like that would be easier to do after making it a single page app (which is necessary to do things like background audio, or shrinking the video player picture in picture style)

jansmolders86 commented 9 years ago

Sorry I've taken so long to respond guys! I've been work pretty much day and night for the last couple of weeks. It'll soon get less busy and when it does I want to prioritize making MCJS a complete onepage angular app which ties in nicely with this issue as Jon mentioned!

Jon889 commented 9 years ago

Work should definitely be the priority, though hopefully you don't work yourself to death :) I'm curious what you ideas were for the search?

jansmolders86 commented 9 years ago

Thanks for understanding. I just don't want you guys to get the feeling I'm abandoning this project. :)

I want to express again I totally love this feature! It's really well done already! And super fast!
I just have a ton of ideas to use this once we have the entire thing in Angular.

I would love to see a Windows 8+ esk search capability that would really fit the project! I'll open an issue for the anugalrisation of the entire projects to discuss it's features.

jansmolders86 commented 9 years ago

So @Jon889 @hoffi , shall we merge this in it's current state? I love the current functionality already and I hate to see us waist this work until we move to the 2.0 version.

Jon889 commented 9 years ago

There are some parts of the implementation I'm not quite happy with, there isn;t really a way to search multiple types of things from the same app (for example tracks and albums in the music app). And the way it knows what directive to use to display the results is odd/too connected.