search

jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 243 forks source link

Version manager #60

Closed jansmolders86 closed 10 years ago

jansmolders86 commented 10 years ago

A user should be able to update MCJS from the client.

jansmolders86 commented 10 years ago

The basic functionality is now finished.

hoffi commented 10 years ago

Wouldn't it be better to do the version checks in a separate Process in a configurable frequency?

Currently the version check is triggered from the client by an AJAX-Call. This blocks further requests (e.g. go to the home screen and click on a tile. The App opens after the version check has been finished), which is not very nice.

jansmolders86 commented 10 years ago

Good call Hoffi, I was planning to tweak this as it is currently a fairly heavy call. I also need to add a npm install if there are new modules included in the core app. Thanks for thinking with me on this. Happy new year!

jansmolders86 commented 10 years ago

FYI, I fixed the call to be less intrusive and drastically faster. I hope this is a more acceptable solution.

https://github.com/jansmolders86/mediacenterjs/commit/3ae2d52666017fcdcdc66d28ab9601db5729fff7

Thanks again!

hoffi commented 10 years ago

Yes this does not block requests anymore. Thanks :)