jansmolders86 / mediacenterjs

A HTML/CSS/Javascript (NodeJS) based Media center
http://mediacenterjs.com
1.29k stars 245 forks source link

Virus reported by Avast with Windows Installer #96

Closed idefy closed 10 years ago

idefy commented 10 years ago

The installer ran correctly, requested to restart PC (win7). After restart, when wanting to launch the mediacenterjs.exe Avast deleted it and declared to have found a File Rep Metagen in it. I did download the installer from www.mediacenterjs.com using chrome.

I don't know if it is a false positive, but since the official site seems to have difficulties to responds, it is hard to know if it is safe or if the site was not hacked and a infected setup was placed.

jansmolders86 commented 10 years ago

No worries, I can totally understand you are hesitant. But luckily I can assure you it is safe. The reason the sites has difficulties is due to the fact a lot of people, of which I'm very grateful, are interested in the project. I'm working on placing the site on a different host to remedy this. (I'm currently hosting on Google and making the switch to Github).

Secondly the reason avast is detecting something wrong with the exe is due to the fact I converted a bat file to an exe. Which imho seems more professional. But sadly the tool I used could not also add the icon to the exe. So, I used an another tool to open the exe and insert the favicon used by the application. Avast is detecting this alteration.

You can also use the original bat file to run the program which can be found here: https://github.com/jansmolders86/mediacenterjs-windows/blob/master/mediacenterjs.bat

I hope I've put your mind at ease. Thanks for trying Mediacenterjs and feel free to ask any other questions you might have.

jansmolders86 commented 10 years ago

Update: The DNS change was successful. The site should run a lot more stable from now on!

vprimachenko commented 10 years ago

you can make the launcher an simple c application

#include <cstdlib>
int main(int argc, char const *argv[]) {
    system("set PATH=%PATH%;%CD%\bin\ffmpeg");
    system("node server.js")
    return 0;
}

and add icon via .rc file

A ICON MOVEABLE PURE LOADONCALL DISCARDABLE "main.ico"

and compile it like

windres -i main.rc --input-format=rc -o rsrc.o -O coff 

and ultimatly add the rsrc.o to the compile line

g++ main.cpp rsrc.o -static
jansmolders86 commented 10 years ago

Wow that is very awesome. I'm ashamed to have to admit I know very little of C. But even I get what this snippet does. :) I will have to familiarize myself with the compilation process of C so I can get this into the windows build, so it may take a little while untill it is added into the build, but again this is really great! Thanks again!

vprimachenko commented 10 years ago

if you want i can supply the compiled exe…

jansmolders86 commented 10 years ago

I didn't dare to ask but that would be amazing if it is not too much trouble.

The icon can be found here: https://github.com/jansmolders86/mediacenterjs/blob/master/public/core/favicon.ico

You can mail me the exe (jansmolders86@gmail.com) or add a pull request in the windows repository: https://github.com/jansmolders86/mediacenterjs-windows

Thanks a lot!

vprimachenko commented 10 years ago

i provided an compiled version in the archive, to compile yourself you'll need windres(eg from mingw/binutils package or my dropbox) and tcc

vprimachenko commented 10 years ago

btw, does the installer really need to restart the pc?

jansmolders86 commented 10 years ago

Awesome! thank you so much! I will definitively test it later today! I can't thank you enough!

And the installer needs to restart because of NodeJS. Node adds environment variables that need to be pickup up. Hence the restart. If you already have node installed you can select "no" and have fun using the project.

jansmolders86 commented 10 years ago

The new installer has been merged in the setup! Thanks again. I scanned it with several virusscanners and they all came up negative. I only got a "unknown publisher" warning the first time I used the exe. I will consider this, case closed :)

jansmolders86 commented 10 years ago

Ps, eventually (I found out), I can compile Nodejs with the project so the nodejs dependency is no longer required during setup and no restart is required.