search

jantari / rewinged

rewinged is a self-hosted winget package source
MIT License
43 stars 6 forks source link

PackageIdentifier with special characters #7

Closed pthuermer closed 1 month ago

pthuermer commented 2 months ago

Hi there,

First of all thank you for such a simple but useful winget personal repo.

I am facing issues when the package identifier is with special characters for example notepad++.

I copied the original manifest and got this error:

PS C:\Users\Administrator> winget install notepad++
An unexpected error occurred while executing the command:
0x8a150044 : The remaining source endpoint is not found.

Replacing all '+' in filename and PackageIdentifier with 'PlusPlus' helped, but updating and listing via winget dos does not work as assumed.

jantari commented 2 months ago

Can you please run rewinged with logLevel set to debug, then re-run winget install notepad++ on a client and copy paste rewinged's output that gets printed during that query?

LogLevel can be set in the Configuration.

Also, does it work when you specify the exact ID? winget install --id "Notepad++.Notepad++" --exact?

Thanks

pthuermer commented 2 months ago

Thank you for your quick response.

comands in PS:

winget source update
winget install notepad++

rewinged debug output

.\rewinged.exe -configFile .\ReWinGed_Config.json
{"level":"debug","time":"2024-08-22T05:50:46-07:00","message":"searching for manifests"}
{"level":"debug","package":"7zip.7zip","packageversion":"23.01","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.06","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"22.01","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"22.00","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.07","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.05","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.1","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.4","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.6","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.2","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.5","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Microsoft.SQLServerManagementStudio","packageversion":"20.2","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.7","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.9","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.08","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"SomePythonThings.WingetUIStore","packageversion":"3.1.1","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.8","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Datalust.Seq","packageversion":"7.0.12250.0","time":"2024-08-22T05:50:46-07:00","message":"found multi-file manifest"}
{"level":"info","time":"2024-08-22T05:50:46-07:00","message":"found 5 package manifests"}
{"level":"info","time":"2024-08-22T05:50:46-07:00","message":"watching manifestPath for changes"}
{"level":"info","time":"2024-08-22T05:50:46-07:00","message":"starting server on http://192.168.255.141:80"}
{"level":"info","client_id":"192.168.255.141","method":"GET","status_code":200,"body_size":100,"path":"/api/information","time":"2024-08-22T05:51:53-07:00"}
{"level":"info","client_id":"192.168.255.141","method":"GET","status_code":200,"body_size":100,"path":"/api/information","time":"2024-08-22T05:51:53-07:00"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"{MaximumResults:0 FetchAllManifests:false Query:{KeyWord: MatchType:} Inclusions:[{PackageMatchField:PackageFamilyName RequestMatch:{KeyWord:notepad++ MatchType:Exact}} {PackageMatchField:ProductCode RequestMatch:{KeyWord:notepad++ MatchType:Exact}} {PackageMatchField:PackageIdentifier RequestMatch:{KeyWord:notepad++ MatchType:CaseInsensitive}} {PackageMatchField:PackageName RequestMatch:{KeyWord:notepad++ MatchType:CaseInsensitive}} {PackageMatchField:Moniker RequestMatch:{KeyWord:notepad++ MatchType:CaseInsensitive}}] Filters:[]}"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"advanced search with inclusions[] and/or filters[]"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.1"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.2"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.9"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.4"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.6"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.5"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.7"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"adding to the results map: Notepad++.Notepad++ version 8.6.8"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"with 1 results"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"package Notepad++.Notepad++ with 9 versions"}
{"level":"debug","time":"2024-08-22T05:51:53-07:00","message":"&{Data:[{PackageIdentifier:Notepad++.Notepad++ PackageName:Notepad++ Publisher:Notepad++ Team Versions:[{PackageVersion:8.6 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.1 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.2 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.9 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.4 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.6 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.5 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.7 Channel: PackageFamilyNames:[] ProductCodes:[]} {PackageVersion:8.6.8 Channel: PackageFamilyNames:[] ProductCodes:[]}]}] RequiredPackageMatchFields:[] UnsupportedPackageMatchFields:[]}"}
{"level":"info","client_id":"192.168.255.141","method":"POST","status_code":200,"body_size":945,"path":"/api/manifestSearch","time":"2024-08-22T05:51:53-07:00"}

comands in PS:

winget source update
winget install --id "Notepad++.Notepad++" --exact

rewinged debug output:

.\rewinged.exe -configFile .\ReWinGed_Config.json
{"level":"debug","time":"2024-08-22T05:54:50-07:00","message":"searching for manifests"}
{"level":"debug","package":"7zip.7zip","packageversion":"22.00","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.05","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"23.01","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.06","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"22.01","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.07","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.4","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.1","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.2","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.7","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.6","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.5","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"SomePythonThings.WingetUIStore","packageversion":"3.1.1","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"7zip.7zip","packageversion":"24.08","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.8","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Microsoft.SQLServerManagementStudio","packageversion":"20.2","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Notepad++.Notepad++","packageversion":"8.6.9","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"debug","package":"Datalust.Seq","packageversion":"7.0.12250.0","time":"2024-08-22T05:54:50-07:00","message":"found multi-file manifest"}
{"level":"info","time":"2024-08-22T05:54:50-07:00","message":"found 5 package manifests"}
{"level":"info","time":"2024-08-22T05:54:50-07:00","message":"watching manifestPath for changes"}
{"level":"info","time":"2024-08-22T05:54:50-07:00","message":"starting server on http://192.168.255.141:80"}
{"level":"info","client_id":"192.168.255.141","method":"GET","status_code":200,"body_size":100,"path":"/api/information","time":"2024-08-22T05:55:26-07:00"}
{"level":"info","client_id":"192.168.255.141","method":"GET","status_code":200,"body_size":100,"path":"/api/information","time":"2024-08-22T05:55:26-07:00"}
{"level":"info","client_id":"192.168.255.141","method":"GET","status_code":200,"body_size":100,"path":"/api/information","time":"2024-08-22T05:56:04-07:00"}
{"level":"info","client_id":"192.168.255.141","method":"GET","status_code":200,"body_size":100,"path":"/api/information","time":"2024-08-22T05:56:04-07:00"}

Both cases resulted in the same error:

PS C:\Users\Administrator> winget install notepad++
An unexpected error occurred while executing the command:
0x8a150044 : The remaining source endpoint is not found.
jantari commented 2 months ago

I cannot reproduce this, it works for me.

I don't think this error is caused by your rewinged source, do you have other custom sources configured? When searching the winget repo issues for that error it appears some folks are getting it from the built-in msstore source: https://github.com/microsoft/winget-cli/issues?q=is%3Aissue+is%3Aopen+0x8a150044

Can you try winget install notepad++ --source rewinged (or whatever you named your rewinged source in winget source list).

jantari commented 2 months ago

Were you able to test whether this error is really caused by rewinged?

Maybe the winget logs can also help narrow it down: winget install notepad++ --verbose-logs

jantari commented 1 month ago

Closing after 2 weeks of inactivity.