jantimon / css-variable

Define CSSVariables in JS
https://css-variable.js.org
MIT License
89 stars 5 forks source link

Unify Babel & SWC #25

Open Mad-Kat opened 1 year ago

Mad-Kat commented 1 year ago

After the latest commits to this project I'm really hooked to improve it further.

One aspect that I noticed that bugs me is that when you switch from Babel to SWC or vice versa, there will be changes for the names of the variables (with and without displayNames).

I have a branch that changes the tests so that the interoperability is checked and I started with changing the babel plugin logic (to be the same as in SWC), because I think the visual names in SWC are much better.

I wanted to ask if this direction is generally a good idea or do you see issues?

martindisch commented 1 year ago

I'm not the owner, but for what it's worth, makes sense to me.