Manifest cannot be loaded if credentials are required

jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you

MIT License

1.2k stars 210 forks source link

Closed ZLJasonG closed 3 years ago

ZLJasonG commented 3 years ago

There doesn't appear to be any option to specify if the crossorigin="use-credentials" should be added to the generated manifest.json link.

As per https://web.dev/add-manifest/#link-manifest this is required to enable cookies to be sent with the manifest request

jantimon commented 3 years ago

You can use the favicons option to configure the underlying favicons npm package https://www.npmjs.com/package/favicons

it provides the loadManifestWithCredentials option

please let me know if this helps :)

ZLJasonG commented 3 years ago

Excellent thanks, that's done the trick. I had just seen the code in generateFaviconsLight and figured it was completely unsupported.