Closed andy128k closed 2 years ago
@jantimon may you enable CI to check this PR?
Thanks for the upgrade - i'll try to release it as an beta in the next days
thanks for the pr @andy128k, i'm using your fork without any issues
would be great to get this released as a beta 👍
just had to change the peerDependencies to allow for the beta
"peerDependencies": {
"webpack": "^5.0.0",
"favicons": ">= 6.2.0 || ^7.0.0-beta.1"
},
@carlhopf I've cherry-picked your commit and added to this PR.
@jantimon gentle bump
😬
Hey. Are there any chances this PR will be merged? ❤️
The latest favicons use manifest.webmanifest
, instead of manifest.json
, resulting in manifest
option of favicons-webpack-plugin being ignored.
As a temporary workaround one can do this under favicons option:
files: {
android: {
manifestFileName: "manifest.json",
},
},
IMO a more proper fix for this should also be included in this PR?
Hi there! Any news?
Hi there! Any news?
Not to pile on, but we need favicons
upgraded >= 7.0.0.
The older favicons
version (^6) currently being referenced has security vulnerabilities.
I see that a PR to fix this issue has been merged. Do we know when the next release will be, though?
Just opened an issue requesting a new release
There is an intention to release favicons 7.0.0 soon. This PR is created to ensure that the upcoming release doesn't break downstream too much.