search

jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you
MIT License
1.2k stars 210 forks source link

Update favicons to 7.0.0 #291

Closed andy128k closed 2 years ago

andy128k commented 2 years ago

There is an intention to release favicons 7.0.0 soon. This PR is created to ensure that the upcoming release doesn't break downstream too much.

andy128k commented 2 years ago

@jantimon may you enable CI to check this PR?

jantimon commented 2 years ago

Thanks for the upgrade - i'll try to release it as an beta in the next days

carlhopf commented 2 years ago

thanks for the pr @andy128k, i'm using your fork without any issues

would be great to get this released as a beta 👍

just had to change the peerDependencies to allow for the beta

  "peerDependencies": {
    "webpack": "^5.0.0",
    "favicons": ">= 6.2.0 || ^7.0.0-beta.1"
  },
andy128k commented 2 years ago

@carlhopf I've cherry-picked your commit and added to this PR.

andy128k commented 2 years ago

@jantimon gentle bump

MikeSha commented 2 years ago

😬

MikeSha commented 2 years ago

Hey. Are there any chances this PR will be merged? ❤️

OctoNezd commented 2 years ago

The latest favicons use manifest.webmanifest, instead of manifest.json, resulting in manifest option of favicons-webpack-plugin being ignored.

As a temporary workaround one can do this under favicons option:

                files: {
                    android: {
                        manifestFileName: "manifest.json",
                    },
                },

IMO a more proper fix for this should also be included in this PR?

n-rodriguez commented 2 years ago

Hi there! Any news?

n-rodriguez commented 2 years ago

Hi there! Any news?

Jarch09 commented 2 years ago

Not to pile on, but we need favicons upgraded >= 7.0.0.

The older favicons version (^6) currently being referenced has security vulnerabilities.

cmloegcmluin commented 2 years ago

I see that a PR to fix this issue has been merged. Do we know when the next release will be, though?

Jarch09 commented 2 years ago

Just opened an issue requesting a new release