jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you
MIT License
1.2k stars 210 forks source link

`[contenthash]` should consider content of manifests #294

Open peterhirn opened 2 years ago

peterhirn commented 2 years ago

Changes to appName, appShortName, etc. and file changes to manifest currently don't affect the content hash. This means the folder can not be safely cached by clients and the prefix needs to be manually updated with every config change, eg. prefix: "assets/[contenthash:8]-v2/".

The [contenthash] should be constructed by hashing input files + full config (including defaults) or alternatively hashing of the output files.

jantimon commented 2 years ago

Could you please create a PR?