jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you
MIT License
1.2k stars 210 forks source link

Make sure examples work #295

Open ChocolateLoverRaj opened 2 years ago

ChocolateLoverRaj commented 2 years ago

Is your feature request related to a problem? Please describe. I downloaded the repo, installed Node.js v10.20.0, and installed dependencies. Then I went to the basic example and ran pnpx webpack serve, and it resulted in an error (probably because there is an old version of webpack-dev-server?).

Describe the solution you'd like The examples should include dependencies like webpack, webpack-cli, and webpack-dev-server, and have scripts in package.json for starting server and building. They should also work with any node version >= the minimum node version.

Describe alternatives you've considered Using the favicon option in HtmlWebpackPlugin.

Additional context I'm using nodist and pnpm on Windows 10.