search

jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you
MIT License
1.2k stars 211 forks source link

options.logo support string array #332

Closed carlhopf closed 1 year ago

carlhopf commented 1 year ago

favicons >= 7.0.0 picks source image by it's size if provided with an array

solves https://github.com/jantimon/favicons-webpack-plugin/issues/265

carlhopf commented 1 year ago

thanks the review 👍 let me know if the changes work, and i'll go ahead and update/rebase the maskable pr

andy128k commented 1 year ago

@carlhopf Oops. It seems, you've changed too much. Now getRelativeOutputPath is invoked later and this.options are not considered in cache calculations.

I pulled your previous commit and made a change on top of it. Please have a look here https://github.com/jantimon/favicons-webpack-plugin/pull/335 . As far as I can see, all tests are passed.

carlhopf commented 1 year ago

ah took me a bit to wrap my head around the internals ;) thanks for the example 👍 updated commit pushed

andy128k commented 1 year ago

Thanks!