search

jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you
MIT License
1.2k stars 210 forks source link

Support favicons 7.x #339

Closed AlecRust closed 2 years ago

AlecRust commented 2 years ago

When I upgrade favicons 6.2.2 → 7.0.1 my webpack build fails:

$ webpack --mode production
/Users/alec/projects/my-project/node_modules/favicons-webpack-plugin/src/index.js:405
    const { html: tags, images, files } = await favicons(logoSource, {
                                                ^

TypeError: favicons is not a function
    at FaviconsWebpackPlugin.generateFaviconsWebapp (/Users/alec/projects/my-project/node_modules/favicons-webpack-plugin/src/index.js:405:49)
    at FaviconsWebpackPlugin.generateFavicons (/Users/alec/projects/my-project/node_modules/favicons-webpack-plugin/src/index.js:315:21)
    at /Users/alec/projects/my-project/node_modules/favicons-webpack-plugin/src/index.js:117:18
    at /Users/alec/projects/my-project/node_modules/favicons-webpack-plugin/src/cache.js:155:5
    at CacheFacade.providePromise (/Users/alec/projects/my-project/node_modules/webpack/lib/CacheFacade.js:337:24)

Node.js v19.0.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
andy128k commented 2 years ago

You need to use favicons-webpack-plugin v6.0.0-alpha.1 with favicons 7.x.