search

jantimon / favicons-webpack-plugin

Let webpack generate all your favicons and icons for you
MIT License
1.2k stars 211 forks source link

favicons in mobile crypto wallet browsers #343

Closed firnprotocol closed 1 year ago

firnprotocol commented 1 year ago

Is your feature request related to a problem? Please describe. mobile crypto wallets like MetaMask and Coinbase Wallet feature in-app browsers, for use with "dapps" (decentralized applications on Ethereum). these browsers display favicons, both in the usual way (tabs), as well as when the dapps prompt the user for a signature or transaction approval.

i am having trouble getting these dapps to display favicons correctly (on Android, Pixel 6a), despite having tried may different things. they display fine in the standard mobile browser, just not in the dapp browsers.

Describe the solution you'd like I would like a way to get these to work for mobile crypto wallet browers. maybe it's also possible with existing tech, but I am not seeing a way.

Describe alternatives you've considered I've tried building using your plugin. i've also tried just the standard

    <link rel="icon" href="favicon.svg">

as well as a variant with rel="shortcut icon", and so on. nothing was successful.

Additional context reproduction requires building a new site and loading it on a mobile crypto wallet browser, say MetaMask mobile. i can assist with this if you'd like. best case i am missing something silly, and this is straightforward to do.

firnprotocol commented 1 year ago

was able to solve this using a single .ico file locally and the HTML:

    <link rel="icon" href="favicon.ico">

haven't had a chance to diagnose what wasn't working with the previous approach... might be worth looking into. i'll close for now.

firnprotocol commented 1 year ago

update: not really solved. the above only worked on MetaMask mobile, tunnelled to a local server via ngrok. was not able to get it to work on Coinbase Wallet under any circumstances, or on MetaMask on the "real" internet. maybe there is some kind of caching going on; very upsetting / annoying.

firnprotocol commented 1 year ago

final update: this was actually an issue with https://faviconkit.com/, which is used as a third-party service by mobile crypto wallets. huge thanks for your excellent work!