Closed zburke closed 1 year ago
Node.js v14 reached end-of-life 2023-04-30.
@andy128k, I understand that Node.js v14 reached EOL a while ago (and that Node.js v16 will reach EOL in a few weeks). It's great to see that you are paying attention to that and keeping your dependencies current. Dropping support for Node.js v14 is totally TOTALLY fine, but it should have been done in a major release. Raising the minimum supported version of engines.node
is analogous to raising the minimum supported version of a peer dependency; this is a breaking change.
v6.0.1 should run in all the same environments where v6.0.0 runs, but it doesn't. That means v6.0.1 wasn't actually a patch release, it was a mis-labeled major release.
Current behaviour 💣
353 introduced breaking changes by raising the
engines.node
version from >= 14 to >= 16, and this change was published in a patch release (v6.0.1) instead of a major release (v7.0.0). This means anybody running node < v16 with a ^6.0.0 or ~6.0.0 dependency onfavicons-webpack-plugin
will no longer be able to build their module, even without making any code changes whatsoever.Expected behaviour ☀️
Patch releases do not contain breaking changes, i.e. v6.0.1 should run in every environment where v6.0.0 runs.
Reproduction Example 👾
Environment 🖥
Node.js v14.21.3 darwin 22.6.0