Closed jantimon closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
next-yak-benchmark | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 12, 2024 0:01am |
yacijs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 12, 2024 0:01am |
The primary change involves implementing a mock version of the keyframes
function in keyframes.ts
that returns an empty string. This mock is intended for scenarios where dynamic runtime behavior isn't necessary, specifically for usage in CSS keyframe animations.
File(s) | Change Summary |
---|---|
packages/next-yak/runtime/mocks/keyframes.ts |
Added a mock implementation for the keyframes function that returns an empty string. Also provided a usage example for CSS keyframe animations. |
In the world of code, where keyframes dance,
A mock steps in with a minimal stance.
No dynamic moves, just a simple string,
Enhancing tests with ease, like a gentle spring.
🐇✨ Code flows smoothly, like a rabbit's leap,
With animations mocked, in dreams we keep. 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Comparing feature/next-yak-internal-keyframes
(b22ce7f) with main
(def05ec)
✅ 2
untouched benchmarks
Doesn't this mean that the dynamic tagged templates aren't correctly typed, as mocks are exposed to the outside world?
those mocks export the public types - so they must be shipped with the correct public typings
did I somehow break those types?
Nono. I wasn't sure if you changed the types as the type signalizes that you can't use any interpolations. But I checked now and it's basically the same as the previous type so that should work :)
this is the
keyframes
mock implementation for #56during jest/vite it's a noop because there is no css extraction compile step
Summary by CodeRabbit
keyframes
function to support testing of CSS keyframe animations.