Closed jantimon closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
next-yak-benchmark | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Jul 16, 2024 2:31pm |
yacijs | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Jul 16, 2024 2:31pm |
This update focuses on enhancing the .github/workflows/codspeed.yml
workflow file. Key changes include adding the environment variable ACTIONS_STEP_DEBUG: true
to the benchmarks
job, adjusting indentation for branch lists and paths under the on
section, and updating the benchmark action version from v1
to v2
. These modifications aim to improve debugging capabilities and ensure the workflow aligns with the latest action versions.
File | Summary |
---|---|
.github/workflows/codspeed.yml |
Added ACTIONS_STEP_DEBUG: true environment variable to the benchmarks job and adjusted indentation of branch lists and paths under the on section. Updated the benchmark action version from v1 to v2 . |
Comparing feature/enabling-step-debug-logging
(3cea88c) with main
(7b34459)
โก 1
improvements
โ
1
untouched benchmarks
Benchmark | main |
feature/enabling-step-debug-logging |
Change | |
---|---|---|---|---|
โก | render KanjiLetterComponentStyled |
346.7 ms | 291.5 ms | +18.93% |
Hey @jantimon, thanks for opening the PR!
In order for the step debug logging to work, you need to set the ACTIONS_STEP_DEBUG
at the repository level, either in the actions variables or secrets.
Can you also bump the CodSpeed action to v2? There is no breaking changes, and it will allow me to have more information on my end
Added a new secret:
Hey @jantimon and @Mad-Kat, I found and fixed the issue in adriencaccia/next-yak@30266b8
(#3)
Bumping @codspeed/benchmark.js-plugin
to the latest 3.1.0
fixes the issue.
The problem was that @codspeed/benchmark.js-plugin@2.2.0
was installed with @codspeed./core@2.3.1
. And between the two versions, the node
introspection that was setting the necessary node
flags changed, thus it was not working anymore.
I analyzed the variance on some runs, and it is quite low, as it was before:
Found 21 runs for adriencaccia/next-yak (30266b8abf1258c83e3de16d64b57c6feb36ad09)
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโ
โ (index) โ average โ standardDeviation โ varianceCoefficient โ range โ rangeCoefficient โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโผโโโโโโโโโโโโโโโโโโโค
โ packages/benchmark/codspeed/dist/index.bench.mjs::render KanjiLetterComponentYak โ '262.9 ms' โ '1.3 ms' โ '0.5%' โ '5.5 ms' โ '2.1%' โ
โ packages/benchmark/codspeed/dist/index.bench.mjs::render KanjiLetterComponentStyled โ '314.6 ms' โ '511.7 ยตs' โ '0.2%' โ '2.1 ms' โ '0.7%' โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโ
I opened https://github.com/jantimon/next-yak/pull/132 to fix all of that!
@adriencaccia wow really cool thank you :)
can we disable step debugging again?
can we disable step debugging again?
Yes, sure!
Adrien gave us a great hint to find out why codspeed became flaky:
Summary by CodeRabbit
ACTIONS_STEP_DEBUG: true
environment variable in the benchmarks job to aid in debugging.codspeed.yml
to improve indentation of branch lists and paths.v1
tov2
to ensure compatibility and access to the latest features.