search

jantimon / next-yak

a streamlined CSS-in-JS solution tailor-made for Next.js, seamlessly combining the expressive power of styled-components syntax with efficient build-time extraction and minimal runtime footprint, ensuring optimal performance and easy integration with existing atomic CSS frameworks like Tailwind CSS
https://yak.js.org
118 stars 4 forks source link

better css class names #46

Closed jantimon closed 9 months ago

jantimon commented 9 months ago

shot-sIr9gJpE shot-udXCnq3g

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 9:11am
codspeed-hq[bot] commented 9 months ago

CodSpeed Performance Report

Merging #46 will not alter performance

Comparing feature/better-css-class-names (37eb9e4) with main (658b730)

Summary

✅ 2 untouched benchmarks

jantimon commented 9 months ago

I guess instead of making the number less readable we should try to remove the number whenever the class name exists only once in the file.

So I reverted the unreadableNumber change and we can reduce the number usage in a future pr

I also added tests

Mad-Kat commented 9 months ago

Strongly agree with your take and thank you for the additional tests :)