search

jantimon / next-yak

a streamlined CSS-in-JS solution tailor-made for Next.js, seamlessly combining the expressive power of styled-components syntax with efficient build-time extraction and minimal runtime footprint, ensuring optimal performance and easy integration with existing atomic CSS frameworks like Tailwind CSS
https://yak.js.org
108 stars 2 forks source link

Moved tsup configurations to config file #81

Closed Mad-Kat closed 5 months ago

Mad-Kat commented 5 months ago

Moved configurations to a new tsup configuration file.

This approach is more readable and maintainable than the current package scripts.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 2:39pm
codspeed-hq[bot] commented 5 months ago

CodSpeed Performance Report

Merging #81 will not alter performance

Comparing unify-tsup-config (f2d8d42) with main (ecee3d1)

Summary

✅ 2 untouched benchmarks

jantimon commented 5 months ago

what is the idea behind this pr?

wouldn't that change the tsup config from explicit to implicit and remove documentation (why we need it each step)?

Mad-Kat commented 5 months ago

what is the idea behind this pr?

wouldn't that change the tsup config from explicit to implicit and remove documentation (why we need it each step)?

I was working on a TypeScript & ESM version of our loaders and I wasn't too sure if I should add another build command for that. I found this solution and thought it would be more expressive. But you're right. In the previous version of the PR we would loose some explicitness, as we don't know why we splitted those commands explicitly.

I've added some comments that should bring back this explicitness with the added benefit that the config is now fully typed and you can read up on options for specific build.

What do you think?