Closed jantimon closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
yacijs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 5, 2024 0:17am |
Comparing feature/css-parsing
(c971a0b) with main
(47d2ed6)
✅ 2
untouched benchmarks
I think the way we handle CSS-Variables changed and that should also be reflected in the docs.
Maybe you actively decided against using
path.scope.generateUidIdentifier
https://github.com/jamiebuilds/babel-handbook/blob/master/translations/en/plugin-handbook.md#generating-a-uid, but It looks to me as if we should use it for our identifiers 😉Thank you for submitting it. It allows me to work further on the CSS prop.
good point - actually my implementation was incomplete
for production we should not return readable css variable names but short css variable names.
added the necessary code here #f9addbe0e00288d51f9171f5764b2b2c855cfa40
Our current approach has an edge case for dynamic styles inside a foreign selector e.g.:
By parsing the css we can split the css correctly and build up the correct css selector.
Bonus: we can get rid of
:where
for faster selectors