search

jantman / awslimitchecker

A script and python package to check your AWS service limits and usage via boto3.
http://awslimitchecker.readthedocs.org/
GNU Affero General Public License v3.0
515 stars 187 forks source link

Incorrect 'Network interfaces per Region' limit #501

Closed jwu2 closed 3 years ago

jwu2 commented 3 years ago

Bug Report

Version

9.0.0

Installation Method

Docker

Supporting Software Versions

3.8.6

Actual Output

Currently the limit checker queries DescribeAccountAttributes API for "max-instances" attribute, then calculate with logic below: This limit is the greater of either the default limit (350) or your On-Demand Instance limit multiplied by 5. The default limit for On-Demand Instances is 20.

Expected Output

According to https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeAccountAttributes.html, "max-instances" attribute is no longer supported.

Instead this limit is available in Service Quotas with Quota code L-DF5E4CA3 and the default value is 5000.

Testing Assistance

Yes

jantman commented 3 years ago

Thanks for reporting this. Yes, that's all correct. I'll work up a fix for this shortly.

jantman commented 3 years ago

A fix for this issue has been merged to the develop branch and is slated for release in 10.0.0 on Monday, December 7, 2020. Anyone who is able to test the fix is strongly encouraged to do so, and comment on this issue with their results. Instructions for installing awslimitchecker from a git branch are available in the Installing for Development documentation.

jwu2 commented 3 years ago

I have tested this check in the develop branch and can confirm it's working properly.

@jantman, thank you for very much for the fix.

jantman commented 3 years ago

Thanks so much for the confirmation!

jantman commented 3 years ago

This has been fixed in 10.0.0, which is now live on PyPI and is being built on the Docker hub right now. Thank you so much for the contribution!