search

jantman / awslimitchecker

A script and python package to check your AWS service limits and usage via boto3.
http://awslimitchecker.readthedocs.org/
GNU Affero General Public License v3.0
514 stars 188 forks source link

'Max spot instance requests per region' limit check is out of date #502

Closed jwu2 closed 3 years ago

jwu2 commented 4 years ago

Bug Report

Version

9.0.0

Installation Method

Docker

Supporting Software Versions

3.8.6

Actual Output

Limit of this check always returns 20.

Expected Output

Refer to https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-spot-limits.html, this is replaced by following six limits:

Testing Assistance

Yes

nakkurt commented 3 years ago

I also ran into this and after speaking with AWS Support I can confirm that the 'Max spot instance requests per region' is no longer used by AWS. Instead, AWS now manages Spot Instance limits in terms of the number of virtual central processing units (vCPUs) and the above 'per region' request limit is not a thing anymore.

Implication: If your code uses awslimitchecker to check for 'Max spot instance requests per region', then you'd probably want to change that until awslimitchecker is updated to better match AWS.

Background: latest AWS docs on this.

jantman commented 3 years ago

Apologies for the delay in dealing with this.

So, it looks like the spot instance limits now match up to the on-demand EC2 limits, in that they're vCPU-based. Handling this for EC2 was a pretty big task (for reference, see #432 and https://awslimitchecker.readthedocs.io/en/latest/changes.html#changelog-8-0-0-vcpu-limits ). It's a bit of a pain, because China and GovCloud don't use the vCPU units yet, so two alternate code paths need to be maintained.

I'll do my best to work on this within the next few days or week.

jantman commented 3 years ago

I've promised a release today that includes a lot of staged changes, and this isn't going to make it. I'm sorry. I'll try to get another out within the next week that includes this.

skraga commented 3 years ago

We step into the same - adding of this will help us a lot with limits monitoring. We can help with China testing as we use both RoW and China partitions. Looking at AWS WebUI - China switched also to vCPU for Spots.

jantman commented 3 years ago

A fix for this has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much!