search

jantman / awslimitchecker

A script and python package to check your AWS service limits and usage via boto3.
http://awslimitchecker.readthedocs.org/
GNU Affero General Public License v3.0
514 stars 188 forks source link

Fix #503 - Handle (A|E)LB per Region Service Quota with units Count or None #507

Closed jantman closed 3 years ago

jantman commented 3 years ago

This fixes #503 by handling the "Classic Load Balancers per Region" and "Application Load Balancers per Region" Service Quotas with Units set to either "Count" or "None". This bug was caused by yet another unannounced/undocumented change by AWS sometime between November 2 and November 9 of this year. See this comment on the issue for details.

codecov-io commented 3 years ago

Codecov Report

Merging #507 (0bb9d3e) into develop (66d346a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         2914      2919    +5     
  Branches       444       445    +1     
=========================================
+ Hits          2914      2919    +5
Impacted Files Coverage Δ
awslimitchecker/quotas.py 100.00% <ø> (ø)
awslimitchecker/services/elb.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66d346a...0bb9d3e. Read the comment docs.