Closed sebasrp closed 3 years ago
Merging #517 (645e22d) into develop (83d00ac) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## develop #517 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 42 +2
Lines 2923 3005 +82
Branches 445 448 +3
=========================================
+ Hits 2923 3005 +82
Impacted Files | Coverage Δ | |
---|---|---|
awslimitchecker/services/elasticache.py | 100.00% <ø> (ø) |
|
awslimitchecker/services/vpc.py | 100.00% <ø> (ø) |
|
awslimitchecker/services/__init__.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/ec2.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/eks.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/kinesis.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/version.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 83d00ac...d8e9d09. Read the comment docs.
Merging #517 (645e22d) into develop (83d00ac) will not change coverage. The diff coverage is
100.00%
.:exclamation: Current head 645e22d differs from pull request most recent head d8e9d09. Consider uploading reports for the commit d8e9d09 to get more accurate results
@@ Coverage Diff @@
## develop #517 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 42 +2
Lines 2923 3005 +82
Branches 445 448 +3
=========================================
+ Hits 2923 3005 +82
Impacted Files | Coverage Δ | |
---|---|---|
awslimitchecker/services/elasticache.py | 100.00% <ø> (ø) |
|
awslimitchecker/services/vpc.py | 100.00% <ø> (ø) |
|
awslimitchecker/services/__init__.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/ec2.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/eks.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/kinesis.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/version.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 83d00ac...d8e9d09. Read the comment docs.
@sebasrp My deepest apologies for letting this sit for so long, but thank you so much for this. It's greatly appreciated that the PR was ready to merge, and the changes to the docs build process are probably for the best so that other contributors can easily build the docs.
Before submitting pull requests, please see the Development documentation and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first three items.
Summary
Fixes #514 - EKS Fargate profile usage check error, which happens when an EKS cluster has a fargate profile without labels
Pull Request Checklist
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms: