search

jantman / awslimitchecker

A script and python package to check your AWS service limits and usage via boto3.
http://awslimitchecker.readthedocs.org/
GNU Affero General Public License v3.0
515 stars 187 forks source link

Added to conda #520

Closed BastianZim closed 3 years ago

BastianZim commented 3 years ago

Hi,

this is more of an FYI than an issue but I just wanted to let the maintainers know that I added awslimitchecker (and versionfinder since awslimitchecker depends on it) to conda-forge so that it can be downloaded with conda.

The repo is here: https://github.com/conda-forge/awslimitchecker-feedstock and https://github.com/conda-forge/versionfinder-feedstock

Let me know if anyone of the maintainers here would like to be added as maintainers there or if I should make a PR here to add a badge or install instructions. Otherwise, feel free to just close the issue.

Thanks! 😃

jantman commented 3 years ago

@BastianZim Apologies for the delay.

Without going into a whole lot of detail here, I haven't been giving awslimitchecker (or any of my other F/OSS projects, though this is the only one that has more than a handful of users) anywhere near the attention that it deserves lately. I've been meaning to fix that, but various personal things have gotten in the way.

I'd be happy to have a PR here with install instructions, and a badge if desired. Regarding maintaining it, I'll sign up for an account, and yes, I'd like to be added as a maintainer... if for no other reason, so that access stays with the current owner of awslimitchecker (me) and can be passed on to the future owner (???) cleanly.

BastianZim commented 3 years ago

@jantman No worries at all, totally understood.

Ok great, will do that momentarily. Conda-forge is completely GitHub based so the account will be your GitHub account. I'll stay as a maintainer as well but of course, if you'd like to add someone else at a later date, that can easily be changed.

jantman commented 3 years ago

Ok cool, thanks so much!

BastianZim commented 3 years ago

Happy to help! I have created the PRs that add you as a code owner so you should get the invite momentarily which will give you push access to the repos. But, as I said, I will still stay on and update etc. them so don't feel pressured to actually maintain them. I just like having the upstream owner onboard because that sometimes makes finding issues that occur somewhere between upstream and feedstock easier. 😄

BastianZim commented 3 years ago

Just to check, I can currently find the install method mentioned once in the README and once in the docs. Would you like me to add the install instructions in both places or do you prefer a different approach?

jantman commented 3 years ago

Cool, thanks so much! Yeah, I definitely agree about having the upstream owner onboard. I've also been the victim of orphaned packages before, so I like to know that if I do eventually pass on ownership of the project, the new owner will have full access.

Hmm... I guess that's some unfortunate duplication. It's up to you... it might be best to put the installation method in the built docs, and just add a line to the README for something like "For Conda install instructions, see the full documentation."

BastianZim commented 3 years ago

Yeah, fully agree! Have had that too...!

Since installing with conda is relatively easy (It's basically just conda install -c conda-forge awslimitchecker) I would suggest adding this command to the README along with a badge indicating the newest version that is currently available (Like so: Conda Version) and then explain the process of creating conda environments and installing the package (As sort of outlined here https://github.com/conda-forge/awslimitchecker-feedstock/blob/master/README.md) in the docs. What do you think?

jantman commented 3 years ago

Sounds good to me! If you can open a PR for that, I'll get it merged & released the next time there's a release... which I hope will be relatively soon.

BastianZim commented 3 years ago

Perfect! Gotta run now but I'll create the PR tomorrow and keep you updated. Thanks!

BastianZim commented 3 years ago

@jantman Just wanted to check in if there's anything else you'd like me to add?

BastianZim commented 3 years ago

Just gently bumping this again @jantman

BastianZim commented 3 years ago

Hi @jantman just wanted to check in if you already had some time to review this, thanks!

jantman commented 3 years ago

A fix for this has been released in 11.0.0, which is now live on PyPI. Thank you so much, and apologies for the delay.

BastianZim commented 3 years ago

Thank you! I'll update the conda-forge version just now.