jantman / awslimitchecker

A script and python package to check your AWS service limits and usage via boto3.
http://awslimitchecker.readthedocs.org/
GNU Affero General Public License v3.0
514 stars 188 forks source link

Add conda download #522

Closed BastianZim closed 3 years ago

BastianZim commented 3 years ago

Before submitting pull requests, please see the Development documentation and specifically the Pull Request Guidelines.

IMPORTANT: Please take note of the below checklist, especially the first three items.

Summary

Add a summary of what your PR does here. This could be as simple as "adds support for X service" or "fixes default limit for Y", or a longer explanation for less straightforward changes.

Adds conda as a download option. Closes #520

Pull Request Checklist

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

codecov-io commented 3 years ago

Codecov Report

Merging #522 (1386ab3) into develop (d0593d8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #522   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3005      3005           
  Branches       448       448           
=========================================
  Hits          3005      3005           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0593d8...9c7e2bc. Read the comment docs.

BastianZim commented 3 years ago

@jantman I have now added conda and tried to follow your code style but let me know if you prefer a different phrasing or formatting somewhere.

BastianZim commented 3 years ago

documentation has been rebuilt with tox -e docs

Just to check, I've done this locally but didn't include anything since I assumed that the CI does that. Or should I include it?

BastianZim commented 3 years ago

Thanks!

jantman commented 3 years ago

This has been released in 11.0.0, which is now live on PyPI. Thank you so much, and apologies for the delay.