Closed TagadaPoe closed 3 years ago
Merging #545 (efe095c) into develop (a829ce2) will not change coverage. The diff coverage is
100.00%
.:exclamation: Current head efe095c differs from pull request most recent head 9e4f162. Consider uploading reports for the commit 9e4f162 to get more accurate results
@@ Coverage Diff @@
## develop #545 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 42 43 +1
Lines 3030 3255 +225
Branches 455 480 +25
==========================================
+ Hits 3030 3255 +225
Impacted Files | Coverage Δ | |
---|---|---|
awslimitchecker/services/__init__.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/services/cloudfront.py | 100.00% <100.00%> (ø) |
|
awslimitchecker/connectable.py | 100.00% <0.00%> (ø) |
|
awslimitchecker/services/ec2.py | 100.00% <0.00%> (ø) |
|
awslimitchecker/services/ecs.py | 100.00% <0.00%> (ø) |
|
awslimitchecker/services/vpc.py | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a829ce2...9e4f162. Read the comment docs.
@TagadaPoe I'm going to try to get to these PRs today, sorry for the delay. Could you please update your PR to allow changes from maintainers? This needs to be rebased on develop, and the others will need to be rebased as I merge them in. Thanks!
Thank you so much for this, and many apologies for it sitting so long!
This has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much, and apologies for the delay!
Don't worry, thank you for the release :+1:
Before submitting pull requests, please see the Development documentation and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first three items.
Summary
Adds support for CloudFront service.
The CloudFront service is considered as global, so the same usage will be reported for CloudFront, no matter which region we are using.
Note: in the "Service Quotas" service, the CloudFront quotas are listed in the region "us-east-1".
The AWS "Service Quotas" service does not return the applied service quotas for CloudFront, only the default quotas.
Note: when rebuilding the doc, there were some changes not related to CloudFront that I did not commit. Maybe an separate documentation update will be needed ?
Pull Request Checklist
tox -e docs
connect()
andconnect_resource()
methods, inherited from awslimitchecker.connectable.ConnectableContributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms: