Virtual private gateways limit does not work anymore

sean-zou commented 3 years ago

Bug Report

When reporting a bug in awslimitchecker, please provide all of the following information, as well as any additional details that may be useful in reproducing or fixing the issue:

Version

awslimitchecker 10.0.0

Installation Method

installed in a virtualenv

Supporting Software Versions

python version 3.8

Actual Output

vpc 'Virtual private gateways' resource usage (0) exceeds warning threshold (limit=5)

Expected Output

The current usage should be around 500, and the limit is 1000.

TrustedAdvisor

Enterprise support

Testing Assistance

I will be able to assist in testing pre-release code for the feature.

jantman commented 3 years ago

@sean-zou I'm unable to reproduce any issues with this in my accounts. Could you please also provide:

Try re-running this with the current version (11.1.0 right now, 12.0.0 should be out today) instead of 10.0.0?
What region you're running in?
The output of awslimitchecker -S VPC -vv -u
The output of aws ec2 describe-vpn-gateways

Thanks.

sean-zou commented 2 years ago

@jantman I've tried the steps above and no problem with those. How ever if I run awslimitchecker -S VPC -vv -l, I see something like this:

VPC/Entries per route table        50.0 (Quotas)
VPC/Internet gateways              65.0 (Quotas)
VPC/NAT Gateways per AZ            5.0 (Quotas)
VPC/Network ACLs per VPC           200.0 (Quotas)
VPC/Network interfaces per Region  1500.0 (Quotas)
VPC/Route tables per VPC           200.0 (Quotas)
VPC/Rules per network ACL          20.0 (Quotas)
VPC/Subnets per VPC                200.0 (Quotas)
VPC/VPCs                           65.0 (Quotas)
VPC/Virtual private gateways       5

Virtual private gateways limit is not getting the current value from Service Quotas. I've created a PR to address that. Please help to review and merge. Thanks! This is what I see after applying the changes in the PR:

VPC/Entries per route table        50.0 (Quotas)
VPC/Internet gateways              65.0 (Quotas)
VPC/NAT Gateways per AZ            5.0 (Quotas)
VPC/Network ACLs per VPC           200.0 (Quotas)
VPC/Network interfaces per Region  1500.0 (Quotas)
VPC/Route tables per VPC           200.0 (Quotas)
VPC/Rules per network ACL          20.0 (Quotas)
VPC/Subnets per VPC                200.0 (Quotas)
VPC/VPCs                           65.0 (Quotas)
VPC/Virtual private gateways       200.0 (Quotas)

sean-zou commented 2 years ago

@jantman while working on this, I also added another related limit Customer gateways. Here is the PR

jantman / awslimitchecker