Entrypoint hardcoded config

jantman / python-amcrest-noauth-proxy

ABANDONED - Python/Flask reverse proxy server that removes HTTP Digest auth from Amcrest IP cameras; Docker image provided

GNU Affero General Public License v3.0

10 stars 4 forks source link

Entrypoint hardcoded config #3

Open mowens3 opened 5 years ago

mowens3 commented 5 years ago

When changing the port in gunicorn_config, I also have to update entrypoint.sh for the workers to reflect that. I ran into some issues with the port forwarding, but was this intentional? It looks like the intention is to load the variables from gunicorn_config. I'm using docker to build.

Thanks and great job on this.

jantman commented 5 years ago

@mowens3 I abandoned work on this project last year... I'm honestly not sure if it was intentional or not, but my memory (and the commit history of this repo is mostly over 3 days) is that I just threw this together, and it was probably just an oversight, or something I never needed so I never took the time to set it up properly.

PRs welcome.

mowens3 commented 5 years ago

Thanks I'll put together a PR on what I found. This App is very useful for aquarium controllers which struggle to embed a noauth URL for different types of cameras.