Closed schultzp2020 closed 7 months ago
I have no idea what the second part of the export-dynamic
script is: yarn export-workflow-editor-envelope:dynamic --clean
...
I've never had the need for this in other frontend plugins for RHDH.
cc @batzionb
cc @caponetto
The --clean
flag is being appended at the end but it affects the second part (extended) of the command.
If things are being appended to the default commands, it means we cannot extend them. Is it correct @davidfestal?
If things are being appended to the default commands, it means we cannot extend them. Is it correct @davidfestal?
It was not designed with this extend-approach in mind yes.
Can you share about what yarn export-workflow-editor-envelope:dynamic
is expected to do ?
Would this comment help building the composite export-dynamic
script you need: https://github.com/yarnpkg/yarn/issues/5207#issuecomment-690583826 ?
the second part is supposed to build files for the kie tools editor but we are changing this anyhow so I can remove it
If things are being appended to the default commands, it means we cannot extend them. Is it correct @davidfestal?
It was not designed with this extend-approach in mind yes.
Can you share about what
yarn export-workflow-editor-envelope:dynamic
is expected to do ?
It builds additional static stuff related to the workflow editor. We have a task to remove that extended part from the export-dynamic
command and serve the files from the backend plugin (see FLPATH-889).
Let me know if the issue here is a blocker. If so, we can remove the second part of the command and wait for FLPATH-889.
@schultzp2020 I didn't manage to reproduce this, is this issue on main? I ran on main branch: yarn run --cwd=./plugins/orchestrator export-dynamic it just built it it didn't run clean
@batzionb I can reproduce it only if I append --clean
at the end of the command.
Would this comment help building the composite
export-dynamic
script you need: yarnpkg/yarn#5207 (comment) ?
Looks like this works:
- "export-dynamic": "janus-cli package export-dynamic-plugin && yarn export-workflow-editor-envelope:dynamic",
+ "export-dynamic": "f() { janus-cli package export-dynamic-plugin \"$@\" && yarn export-workflow-editor-envelope:dynamic; }; f",
with yarn --cwd ./plugins/orchestrator export-dynamic --clean
Would this comment help building the composite
export-dynamic
script you need: yarnpkg/yarn#5207 (comment) ?Looks like this works:
- "export-dynamic": "janus-cli package export-dynamic-plugin && yarn export-workflow-editor-envelope:dynamic", + "export-dynamic": "f() { janus-cli package export-dynamic-plugin \"$@\" && yarn export-workflow-editor-envelope:dynamic; }; f",
with
yarn --cwd ./plugins/orchestrator export-dynamic --clean
This does not work on windows.
@schultzp2020 Is this a blocker for anything right now? It'll be solved in FLPATH-889
@schultzp2020 Is this a blocker for anything right now? It'll be solved in FLPATH-889
Somewhat, this bug significantly complicates the maintenance of the plugins repository since we frequently need to regenerate the lockfiles, although it's not a critical issue.
Thanks @batzionb!
Given the circumstances, we were able to remove the extended part of the command but it'd be nice if we could extend the commands in a platform-agnostic way. Let's keep that in mind if we ever need to do it again.
@schultzp2020 Can you please verify and close the issue?
lgtm
Describe the bug
The Orchestrator plugin's
export-dynamic
command does not workExpected Behavior
The Orchestrator plugin's
export-dynamic
command does workWhat are the steps to reproduce this bug?
yarn run --cwd ./plugins/orchestrator export-dynamic
Versions of software used and environment