search

janus-idp / backstage-plugins

Plugins for Backstage
https://janus-idp.io
Apache License 2.0
125 stars 127 forks source link

fix(cli): fix the removal of type definitions by `export-dynamic`. #1810

Closed davidfestal closed 2 weeks ago

davidfestal commented 2 weeks ago

This PR fixes the erroneous removal of dist/*.d.ts files by the export-dynamic command, when used on backend plugins with the no-embed-as-dependencies option.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-plugins/blob/main/OWNERS)~~ [schultzp2020] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidfestal commented 2 weeks ago

/hold