search

janus-idp / backstage-plugins

Plugins for Backstage
https://janus-idp.io
Apache License 2.0
125 stars 127 forks source link

feat(keycloak): expose keycloak user/group transformer extension point #1825

Closed JessicaJHee closed 1 week ago

JessicaJHee commented 1 week ago

Resolves RHIDP-2644: Expose extension points for the keycloak-backend plugin

To test this change locally, this may be useful - it adds a new module that uses the extension point to append _foo and _bar to the group and user name respectively.

kim-tsao commented 1 week ago

I was going to ask where the unit tests were but it looks like they were added before.

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-plugins/blob/main/OWNERS)~~ [kim-tsao] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nickboldt commented 6 days ago

I'm not clear in 1.2.x branch of showcase where this change was picked up https://github.com/janus-idp/backstage-showcase/commits/1.2.x/

please clarify if this is being cherrypicked to 1.2.2 or only for 1.3.