search

janus-idp / backstage-plugins

Plugins for Backstage
https://janus-idp.io
Apache License 2.0
145 stars 146 forks source link

fix(rbac): simplify db logic #1831

Closed AndrienkoAleksandr closed 3 months ago

AndrienkoAleksandr commented 3 months ago

What does this pull request do:

Drop policy source database table, move this data to the cabin db table.

What does this pull request fix:

https://issues.redhat.com/browse/RHIDP-1528

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from andrienkoaleksandr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/janus-idp/backstage-plugins/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AndrienkoAleksandr commented 3 months ago

I have been thinking about this some more. Do we need to store the source information any more with the policies if we are just going to reference the role metadata for the source?

I also thought about that, which is why I spent two days preparing an alternative PR: https://github.com/janus-idp/backstage-plugins/pull/1842 on top of the current changes. Please take a look.

AndrienkoAleksandr commented 3 months ago

Close on favour: https://github.com/janus-idp/backstage-plugins/pull/1842