search

janus-idp / backstage-plugins

Plugins for Backstage
https://janus-idp.io
Apache License 2.0
145 stars 146 forks source link

fix(rbac): casbinDBAdapterFactory supporting postgres schema configuration #1841

Closed luangazin closed 3 months ago

luangazin commented 3 months ago

When Backstage uses a single database, the casbin_rule table is created in the public schema instead of the permission schema. https://backstage.io/docs/tutorials/switching-sqlite-postgres/#using-a-single-database

image

AndrienkoAleksandr commented 3 months ago

I tested, works fine. Looks LGTM for me. What do you think @PatAKnight ?

PatAKnight commented 3 months ago

Looks like it is failing on the yarn prettier:check command, should just need to run yarn prettier:fix to fix the styling issues.

luangazin commented 3 months ago

Looks like it is failing on the yarn prettier:check command, should just need to run yarn prettier:fix to fix the styling issues.

Hi,

The style has been fixed.

Thank you.

AndrienkoAleksandr commented 3 months ago

+1 to merge. @PatAKnight ?

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrienkoAleksandr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-plugins/blob/main/OWNERS)~~ [AndrienkoAleksandr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment