search

janus-idp / backstage-plugins

Plugins for Backstage
https://janus-idp.io
Apache License 2.0
145 stars 146 forks source link

fix(rbac): simplify db logic #1842

Closed AndrienkoAleksandr closed 2 months ago

AndrienkoAleksandr commented 3 months ago

What does this pull request do:

Drop policy source.

What does this pull request fix:

https://issues.redhat.com/browse/RHIDP-1528

AndrienkoAleksandr commented 2 months ago

The only thing that does not happen is if I add a role to the CSV file that matches a legacy role in the database. In this scenario, the source stays as legacy. Also, yarn tsc is failing because CSV_PERMISSION_FILE_AUTHOR is declared in the csv-file-watcher.test.ts but never used.

Fixed.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-plugins/blob/main/OWNERS)~~ [PatAKnight] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment