janus-idp / backstage-plugins

Plugins for Backstage

https://janus-idp.io

Apache License 2.0

125 stars 127 forks source link

fix(rbac): update rbac common to fix compilation #1858

Closed AndrienkoAleksandr closed 1 day ago

AndrienkoAleksandr commented 2 days ago

What does this pull request do:

Update rbac common to fix RBAC plugin compilation .

karthikjeeyar commented 2 days ago

@AndrienkoAleksandr Orchestrator backend also uses rbac-common plugin - https://github.com/janus-idp/backstage-plugins/blob/main/plugins/orchestrator-backend/package.json#L88, this needs to be updated as well ?

karthikjeeyar commented 2 days ago

FYI, I tried to bump the rbac-common in my permission support for argocd PR, but still it failed with build errors. I will revert my changes in that PR in favour of this one.

batzionb commented 2 days ago

changes in orchestrator look good Is there a need for changes in yarn.lock?

batzionb commented 2 days ago

/lgtm

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: batzionb, PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-plugins/blob/main/OWNERS)~~ [PatAKnight] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment