Closed gashcrumb closed 4 months ago
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1245
!
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1245
!
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1245
!
/retest
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1245
!
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1245
!
Verified this is working great. I have this config
if:
allOf:
- isAvailableUsingContext
As well as an exception in simple-test-components/src/plugin.ts
export const isAvailableUsingContext = (
_entity: Entity,
_context: { apis: ApiHolder }
) => {
throw new Error("Test exception for isAvailableUsingContext");
};
When tested on main branch it throws an error and breaks the entire UI. While with this PR's update it loads the rest of catalog entity tabs only the simple-test-component doesn't get load. Also the warning in console shows up as expected.
/lgtm
verfied the changes locally /lgtm /approve
/approve
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ciiay, debsmita1, invincibleJai
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The image is available at: quay.io/janus-idp/backstage-showcase:pr-1245
!
/retest
/retest
github happy path tests seem to have:
/retest
Description
This change adds exception handling to the two points where plugin supplied condition functions are evaluated, once when rendering the catalog entity tabs, and a second time when a plugin's mountpoint configuration is being checked. This change also makes the ApiHolder context object available as a 2nd argument; available at the second evaluation point.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
An easy way to test this is to throw an exception from here and use this plugin. The configuration for this would look like: