janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
105 stars 141 forks source link

feat(argocd-plugin): add rh-argocd plugin as dynamic plugin #1247

Closed karthikjeeyar closed 2 months ago

karthikjeeyar commented 2 months ago

Description

This bundles the RH argocd plugin as a dynamic plugin

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-995

How to test changes / Special notes to the reviewer

Testing using the image

  1. Start RHDH using the image from the PR

  2. Enable the argocd backend and frontend plugins in the dynamic plugins configmap in your namespace


includes:
- dynamic-plugins.default.yaml
plugins:
  - package: ./dynamic-plugins/dist/roadiehq-backstage-plugin-argo-cd-backend-dynamic
    disabled: false
  - package: ./dynamic-plugins/dist/janus-idp-backstage-plugin-argocd
    disabled: false
  1. Update the redhat-developer-hub-app-config configmap with following argocd configuration

    argocd:
    baseUrl: https://<argocd-url>
    appLocatorMethods:
    - instances:
      - name: main
        password:  ${ARGOCD_PWD}
        url: https://<argocd-url>
        username:  ${ARGOCD_USERNAME}
      type: config
    

    Screenshots from RHDH cluster:

image


Testing locally

  1. Update the entity with the argocd/app-selector metadata.
    
    annotations:
    argocd/app-selector: 'rht-gitops.com/janus-argocd=quarkus-app-bootstrap'
2. Navigate to `packages/app` and run `yarn build`.
3. Add the following in `app-config.yaml` or `app-config.local.yaml` file

argocd: baseUrl: https:// appLocatorMethods:

dynamicPlugins: rootDirectory: dynamic-plugins-root frontend: janus-idp.backstage-plugin-argocd: mountPoints:

CD tab: image

Overview Page: image

Administration:

image

karthikjeeyar commented 2 months ago

cc: @nickboldt @davidfestal

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

nickboldt commented 2 months ago

Seems reasonable; did not test.

nickboldt commented 2 months ago

/assign @davidfestal

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

karthikjeeyar commented 2 months ago

/test e2e-tests

subhashkhileri commented 2 months ago

/test e2e-tests

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1247!

karthikjeeyar commented 2 months ago

/test e2e-tests

karthikjeeyar commented 2 months ago

/test e2e-tests

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [gashcrumb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
karthikjeeyar commented 2 months ago

/test e2e-tests

karthikjeeyar commented 2 months ago

Google sign in e2e tests are failing due to the presence of Captcha screen, There is a PR to skip this test https://github.com/janus-idp/backstage-showcase/pull/1251 temporarily.

karthikjeeyar commented 2 months ago

/test e2e-tests