Fixing rbac tests execution

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution

https://showcase.janus-idp.io

Apache License 2.0

105 stars 140 forks source link

Fixing rbac tests execution #1248

Closed gustavolira closed 2 weeks ago

gustavolira commented 2 months ago

Description

Update openshift-ci-tests.sh to echo RESULT

Changed the behavior in openshift-ci-tests.sh to echo the result instead of exiting the script using the RESULT variable. This modification allows further actions or analysis after the droute_send function call.

Which issue(s) does this PR fix

RBAC tests execution

PR acceptance criteria

Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from subhashkhileri. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[.ibm/OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/.ibm/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1248!

openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.