chore: rename .eslint to .eslint.json

nickboldt commented 2 months ago

What does this PR do?

we recently switched from .eslintrc.js to .eslintrc https://github.com/janus-idp/backstage-showcase/commit/5287a755987f8d100a7ab5d3e6a05f39f363d539 to fix some issues with linting .mjs files https://github.com/janus-idp/backstage-showcase/pull/1233

But I've realized we should have called it .eslintrc.json:

.eslintrc.json is the most similar to what you're used to, it's the same format but 
with an explicit JSON extension. If you'd like to avoid extra files, you can 
alternatively add your config to the eslintConfig field of package.json. If you need 
dynamic code, use .eslintrc.js or .eslintrc.cjs.

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://stackoverflow.com/questions/62340976/is-the-config-file-eslintrc-deprecated-in-favor-of-eslintrc-files

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [schultzp2020] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1250!

nickboldt commented 2 months ago

prow failing with timeouts:

{google-signin-happy-path.spec.ts:28:3 Verify Google Sign in FAILURE 
  [showcase] › e2e/google-signin-happy-path.spec.ts:28:3 › Google signin happy path › Verify Google Sign in 

    TimeoutError: locator.click: Timeout 60000ms exceeded.