search

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
105 stars 140 forks source link

chore(deps): update RHDH theme #1252

Closed jerolimov closed 2 months ago

jerolimov commented 2 months ago

Description

Update RHDH theme to include:

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

How to test changes / Special notes to the reviewer

jerolimov commented 2 months ago

/assign /cc @invincibleJai @ciiay @karthikjeeyar

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1252!

jerolimov commented 2 months ago

/retest

jerolimov commented 2 months ago

/retest

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1252!

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1252!

invincibleJai commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [invincibleJai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ciiay commented 2 months ago

I know it's already merged, but I finally got the local image work to test it out, here's the screen recording.

https://github.com/janus-idp/backstage-showcase/assets/26255262/59901e22-7433-4b6e-9e9e-c9a92ab87814