search

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
105 stars 140 forks source link

RHIDP-428 RP Fix nightly URL and hostnames to secrets #1254

Closed zdrapela closed 2 months ago

zdrapela commented 2 months ago

Description

Fix URL for nightly job. Move couple of URLs to secrets.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

How to test changes / Special notes to the reviewer

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1254!

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1254!

subhashkhileri commented 2 months ago

/approve

subhashkhileri commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[.ibm/OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/.ibm/OWNERS)~~ [subhashkhileri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment