feat(catalog): added created at column in the catalog page

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution

https://showcase.janus-idp.io

Apache License 2.0

105 stars 140 forks source link

feat(catalog): added created at column in the catalog page #1257

Closed debsmita1 closed 2 months ago

debsmita1 commented 2 months ago

Description

The PR adds the scaffolder annotator action in the backend
In the UI, the catalog page will now show a new Created At column for entity kind Component
The new column can be sorted
Has E2E test

Which issue(s) does this PR fix

Fixes

https://issues.redhat.com/browse/RHIDP-2104 https://issues.redhat.com/browse/RHIDP-2193

Screenshots/GIF

Screenshot 2024-05-14 at 1 42 25 PM

Test setup

Test setup:

Changes in app-config.yaml

catalog:
  location:
    # Example template
    - type: url
      target: https://github.com/debsmita1/nodejs-ex-1/blob/master/local-template.yaml
      rules:
        - allow: [Template]

Use the Create React App Template with timestamping template to register the entity

Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1257!

subhashkhileri commented 2 months ago

e2e tests changes looks good to me.

Zaperex commented 2 months ago

Tested this PR and the timestamp showed up as expected in the column:

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Zaperex commented 2 months ago

Tested again and column renders properly for the entities in the catalog with the timestamp annotation. Components: APIs: Resources: Systems: Templates: Users:

github-actions[bot] commented 2 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1257!

ciiay commented 2 months ago

Tested working great on both local and on OCP 4.14

https://github.com/janus-idp/backstage-showcase/assets/26255262/e3f3acdd-ab7a-47c6-9436-c0ab1a0e72e9

invincibleJai commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [invincibleJai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment