janus-idp / backstage-showcase

This repo is moving to https://github.com/redhat-developer/red-hat-developer-hub
https://showcase.janus-idp.io
Apache License 2.0
110 stars 143 forks source link

fix(app-backend): part 2 - restore external... #1263

Closed nickboldt closed 4 months ago

nickboldt commented 4 months ago

What does this PR do?

fix(app-backend): part 2 - restore external config schema support

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)~~ [davidfestal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
github-actions[bot] commented 4 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1263!

openshift-ci[bot] commented 4 months ago

New changes are detected. LGTM label has been removed.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 4 months ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1263!

nickboldt commented 4 months ago

Proof this worked, thanks to @davidfestal !

image

nickboldt commented 4 months ago

building downstream in https://gitlab.cee.redhat.com/rhidp/rhdh/-/pipelines/8186687