janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
103 stars 139 forks source link

chore(docker): set the `NODE_OPTIONS=--no-node-snapshot` env variable #1277

Closed Zaperex closed 1 month ago

Zaperex commented 1 month ago

Description

Adds the NODE_OPTIONS=--no-node-snapshot env variable so that the scaffolder is usable in nodejs 20.

Which issue(s) does this PR fix

Please make sure that the following steps are complete:

How to test changes / Special notes to the reviewer

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1277!

Zaperex commented 1 month ago

/retest

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1277!

rm3l commented 1 month ago

/test e2e-tests

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rm3l Once this PR has been reviewed and has the lgtm label, please ask for approval from zaperex. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment