search

janus-idp / backstage-showcase

Enterprise-ready Backstage distribution
https://showcase.janus-idp.io
Apache License 2.0
103 stars 139 forks source link

chore(deps): update dependency @smithy/util-utf8 to v3 #1279

Closed renovate[bot] closed 1 month ago

renovate[bot] commented 1 month ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@smithy/util-utf8 (source) 2.3.0 -> 3.0.0 age adoption passing confidence

Release Notes

awslabs/smithy-typescript (@​smithy/util-utf8) ### [`v3.0.0`](https://togithub.com/awslabs/smithy-typescript/blob/HEAD/packages/util-utf8/CHANGELOG.md#300) [Compare Source](https://togithub.com/awslabs/smithy-typescript/compare/@smithy/util-utf8@​2.3.0...@smithy/util-utf8@​3.0.0) ##### Major Changes - [`671aa70`](https://togithub.com/awslabs/smithy-typescript/commit/671aa704): update to node16 minimum ##### Patch Changes - Updated dependencies \[[`671aa70`](https://togithub.com/awslabs/smithy-typescript/commit/671aa704)] - [@​smithy/util-buffer-from](https://togithub.com/smithy/util-buffer-from)[@​3](https://togithub.com/3).0.0

Configuration

šŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

šŸš¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.

ā™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

šŸ”• Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Mend Renovate. View repository job log here.

openshift-ci[bot] commented 1 month ago

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a janus-idp member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1279!

davidfestal commented 1 month ago

/hold

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from davidfestal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/janus-idp/backstage-showcase/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1279!

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1279!

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1279!

davidfestal commented 1 month ago

This package is special and should not be upgraded to 3.0.0 without a deep analysis. See the fix in the export-dynamic-plugin CLI command and the added yarn resolution in exported backend dynamic plugins.

cc @schultzp2020 @nickboldt

kim-tsao commented 1 month ago

We can close this based on the comment https://github.com/janus-idp/backstage-showcase/pull/1279#pullrequestreview-2082050491. Note this is a major dep update which we should gate with dashboard approval in renovate (there's still a TODO to update the config in this repo)

renovate[bot] commented 1 month ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.